smaheshwar-pltr commented on code in PR #3220:
URL: https://github.com/apache/iceberg-python/pull/3220#discussion_r3269589024
##########
tests/integration/test_catalog.py:
##########
@@ -866,3 +875,36 @@ def test_load_missing_table(test_catalog: Catalog,
database_name: str, table_nam
with pytest.raises(NoSuchTableError):
test_catalog.load_table(identifier)
+
+
[email protected]
[email protected]("test_catalog", CATALOGS)
+def test_replace_table_transaction(test_catalog: Catalog, database_name: str,
table_name: str) -> None:
Review Comment:
This test exercises only the RTAS path. The DDL-only invariant — that after
a replace with no follow-up write, `current_snapshot_id` is `None` because the
`main` branch ref was removed — is covered against InMemoryCatalog + SqlCatalog
by
[`test_replace_transaction`](https://github.com/apache/iceberg-python/blob/a810a15025c6aad691e2cb5903cdfe910da5ded5/tests/catalog/test_catalog_behaviors.py#L426)
in the catalog-behavior suite. Backends do not differentiate "DDL-only commit"
from "DDL+write commit" at the protocol layer (both go through `_commit_table`
with whatever updates the txn produced), so a separate integration variant for
that case adds little signal beyond what the behavior layer already pins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
