smaheshwar-pltr commented on code in PR #3220:
URL: https://github.com/apache/iceberg-python/pull/3220#discussion_r3270369841
##########
pyiceberg/catalog/__init__.py:
##########
@@ -444,6 +449,90 @@ def create_table_if_not_exists(
except TableAlreadyExistsError:
return self.load_table(identifier)
+ def replace_table_transaction(
Review Comment:
Pointing out that I've made this a concrete method and _not_ abstract -
curious for thoughts!
Originally, I had this be abstract and overrode in `RestCatalog` and
`MetastoreCatalog`. I then realised that the way PyIceberg is wired up, the
methods are identical and so I collapsed into a concrete method here.
(`replace_table_transaction` differs from `create_table_transaction` in that
the latter requires a `stage-create` flag to be sent to the REST server;
there's no such flow for `replace_table_transaction`s).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
