fallintoplace opened a new pull request, #664: URL: https://github.com/apache/iceberg-cpp/pull/664
## Summary Fixes #663. This implements `ManifestGroup::FilterFiles()` instead of accepting the filter as a silent no-op. The change adds a `DataFile` `StructLike` wrapper, binds and caches file-level evaluators per partition spec, and applies the evaluator to each manifest entry before returning it. The reader projection now also includes file-filter referenced metadata columns when callers use `Select(...)`, including widening nested partition references to the full `partition` struct so partition filters evaluate against the correct positional values. ## Tests - `uvx pre-commit run --files src/iceberg/manifest/manifest_group.cc src/iceberg/row/manifest_wrapper.cc src/iceberg/row/manifest_wrapper.h src/iceberg/test/manifest_group_test.cc` - `uvx cmake --build build --target manifest_test -j 8` - `./build/src/iceberg/test/manifest_test --gtest_filter='ManifestGroupVersions/ManifestGroupTest.FilterFiles*'` - `./build/src/iceberg/test/manifest_test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
