dramaticlly opened a new pull request, #16449:
URL: https://github.com/apache/iceberg/pull/16449
Closes #16445
Remove all methods, classes, and fields marked with "@deprecated will be
removed in 1.12.0" across all modules, since 1.11.0 has been released.
## Deleted Classes
- `SystemProperties` → use `SystemConfigs`
- `PartitionStats` → use `PartitionStatistics` interface /
`BasePartitionStatistics`
- `DataReader` → use `PlannedDataReader`
- `GenericAppenderFactory` → use `GenericFileWriterFactory`
- `BaseFileWriterFactory` → use `RegistryBasedFileWriterFactory`
- `S3SignRequest`, `S3SignResponse`, `S3SignRequestParser`,
`S3SignResponseParser`, `S3ObjectMapper` → use `RemoteSign*` equivalents
## Notable Non-Mechanical Changes
Beyond deleting deprecated code, the following adjustments were needed:
1. **`PositionDelete.set(path, pos, row)` and `row()`** — Kept without
`@Deprecated`. Although the public deprecation notice said position deletes
with row data are no longer
supported, internal code (`BaseTaskWriter`, `BasePositionDeltaWriter`,
`RewriteTablePathUtil`, `Avro`) still relies on these methods.
2. **`BaseScan.io()`** — Kept as a non-deprecated `protected` method.
Internal subclasses (`DataScan`, `BaseDistributedDataScan`) use it; the
deprecation was for external
callers.
3. **`HadoopFileIO.serializeConfWith()`** — Kept without `@Deprecated`
because it implements the `HadoopConfigurable` interface contract. Also inlined
constructor logic since
the removed constructor was the delegation target.
4. **`BaseParquetReaders.createStructReader(List, StructType, Integer)`**
— Changed from a concrete method (that delegated to the removed 2-param
version) to `abstract`. Both
existing subclasses (`InternalReader`, `GenericParquetReaders`) already
override it.
5. **`RewriteTablePathUtil.PositionDeleteReaderWriter.writer()`** — The
4-arg method was a `default` delegating to the removed 5-arg version. Made it
`abstract`; updated all
implementors (`RewriteTablePathSparkAction` in v3.5/v4.0/v4.1) to
implement the 4-arg signature directly.
6. **`S3V4RestSignerClient`** — Removed deprecated property fallback logic
from `baseSignerUri()`, `endpoint()`, and `check()`. The legacy properties
(`s3.signer.uri`,
`s3.signer.endpoint`) are no longer supported.
7. **`Parquet.java`** — Removed the
`NETFLIX_UNSAFE_PARQUET_ID_FALLBACK_ENABLED` branch; without the config, always
use `NameMapping.empty()` (the safe default).
8. **`MetricsConfig.forPositionDelete(Table)`** — All callers
(`FlinkAppenderFactory`, `RegistryBasedFileWriterFactory`) updated to use the
no-arg `forPositionDelete()` since
row-level position delete metrics are no longer supported.
9. **`GenericFileWriterFactory`** — Re-added `writerProperties` to the
constructor and Builder since it was a public non-deprecated setter used by
`GenericAppenderHelper` and
kafka-connect `RecordUtils`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
