fallintoplace commented on PR #1098: URL: https://github.com/apache/iceberg-go/pull/1098#issuecomment-4501436799
Thanks both, that distinction makes sense. I pushed `d3627bc` for the pieces that still belong in this PR: - cleaned up `mayContainNans` so the float/double path is explicit - added `EqualTo` and `IsIn` coverage for the missing-null-count guard I left `VisitNotEqual` / `VisitNotIn` unchanged here after Tanmay’s @tanmayrauth note, since those branches need the Java-style `containsNullsOnly` / `containsNaNsOnly` behavior rather than the `mayContain*` helper used by the range/equality/IN paths. I opened #1103 for that follow-up so this PR stays scoped to the missing-metric conservative handling. Could you take another look when you get a chance? @laskoviymishka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
