kevinjqliu commented on code in PR #16495: URL: https://github.com/apache/iceberg/pull/16495#discussion_r3277758389
########## site/docs/how-to-release.md: ########## @@ -356,15 +356,17 @@ cp -R apache-iceberg-1.8.0/site/docs/javadoc/1.8.0 1.8.0 Once this is done, create a PR against the `javadoc` branch, similar to https://github.com/apache/iceberg/pull/12412. -#### Release versioned docs and javadoc - -Please follow the instructions on the GitHub repository in the [`README.md` in the `site/`](https://github.com/apache/iceberg/tree/main/site) directory. - #### Site update Submit a PR, following the approach in https://github.com/apache/iceberg/pull/12242, to update the Iceberg version, the links to the new version's documentation, and the release notes. +Once this PR is merged, the [`site-ci`](https://github.com/apache/iceberg/blob/main/.github/workflows/site-ci.yml) +GitHub Actions workflow is automatically triggered for any push to `main` that touches `docs/`, `site/`, +or `format/`. The workflow runs `make deploy` to build and push the documentation site to the `asf-site` +branch, which publishes the new version's docs and javadoc. Manually running `make deploy` is no longer +required as part of the release. Review Comment: ```suggestion branch, which publishes the new version's docs and javadoc. The site will be updated automatically. Manually running `make deploy` is no longer required as part of the release. ``` nit ########## site/docs/how-to-release.md: ########## Review Comment: also nit: can we sub out the old PR links with the newest from the 1.11.0 release revapi: https://github.com/apache/iceberg/pull/16412 issue template: https://github.com/apache/iceberg/pull/16413 DOAP: https://github.com/apache/iceberg/pull/16415 docs: https://github.com/apache/iceberg/pull/16427 javadoc: https://github.com/apache/iceberg/pull/16428 Site update: https://github.com/apache/iceberg/pull/12242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
