tanmayrauth commented on issue #1107: URL: https://github.com/apache/iceberg-go/issues/1107#issuecomment-4504183715
Between the two options, I'd lean toward rejecting reserved metadata column IDs in user-supplied schemas that matches Java's Schema::checkCompatibility behavior, keeps a single source of truth for the rule (the existing IsMetadataColumn check), and avoids leaving a footgun where callers who do pass _row_id get a schema that silently still works but breaks against Java-written files. Concretely: run the reserved-ID portion of checkSchemaCompatibility before reassignIDs in NewMetadataWithUUID, and rework scanner_internal_test.go (around line 434) which currently constructs a schema with iceberg.RowID() inline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
