qlong commented on code in PR #15385:
URL: https://github.com/apache/iceberg/pull/15385#discussion_r3278511791
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkV2Filters.java:
##########
@@ -354,7 +354,21 @@ private static <T> T childAtIndex(Predicate predicate, int
index) {
private static boolean canConvertToTerm(
org.apache.spark.sql.connector.expressions.Expression expr) {
- return isRef(expr) || isSystemFunc(expr);
+ return isRef(expr) || isSystemFunc(expr) || isVariantGetFunc(expr);
+ }
+
+ private static boolean isVariantGetFunc(
+ org.apache.spark.sql.connector.expressions.Expression expr) {
Review Comment:
Actually I tried but think better to follow the existing code (from
spark4.0 or 3.5). it clashed with iceberg Expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
