plusplusjiajia commented on PR #3120: URL: https://github.com/apache/iceberg-python/pull/3120#issuecomment-4507297008
> Drive by review - This is a very AWS-centric thing that lives pretty deep in our request sending logic. It would be great to attach this to the AuthManager. Thanks @rambleraptor — good call, reworked it. SigV4 is now a SigV4AuthManager that wraps a delegate AuthManager (delegate does header auth, then SigV4 signs) — mirrors Iceberg Java's RESTSigV4AuthManager. No more transport-layer HTTPAdapter. Added auth.type=sigv4; legacy rest.sigv4-enabled still works via a shim, so nothing breaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
