fallintoplace commented on PR #1112: URL: https://github.com/apache/iceberg-go/pull/1112#issuecomment-4512143413
Thanks, good catch. I pushed `217aa9f` to use floored division for the ns -> us downcast and added a pre-epoch regression with `timestamp[ns] = -1500` into an Iceberg `timestamp` source field. The test asserts both the converted partition value (`-2` micros) and the resulting partition path. I agree `Time64` looks like the same shape but separate from this timestamp partition fix; I’ll leave that for a follow-up. Retested: - `go test ./table -run TestFanoutWriter -count=1` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
