mzzz-zzm commented on issue #1028: URL: https://github.com/apache/iceberg-go/issues/1028#issuecomment-4513926400
Are we agreed to apply the fixes listed below? 1. Fix the known broken consumer toDecimalLiteral: take the precision from the bound field’s DecimalType, not from v.Type(). 2. Fix the latent panic on the same line — v.Type().(*iceberg.DecimalType) performs a pointer type assertion on a value type. Change it to v.Type().(iceberg.DecimalType). 3. Document the caveat on DecimalLiteral.Type(). If the above looks good, I can proceed with the changes. 4. Add simple regression test <-- if desired -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
