zhjwpku commented on code in PR #670:
URL: https://github.com/apache/iceberg-cpp/pull/670#discussion_r3285818625
##########
cmake_modules/IcebergThirdpartyToolchain.cmake:
##########
@@ -248,6 +248,11 @@ function(resolve_avro_dependency)
set(AVRO_VENDORED TRUE)
set_target_properties(avrocpp_s PROPERTIES OUTPUT_NAME
"iceberg_vendored_avrocpp")
set_target_properties(avrocpp_s PROPERTIES POSITION_INDEPENDENT_CODE ON)
+ if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
+ # Work around AppleClang 21 rejecting fmt's consteval format-string
checks
+ # while compiling vendored avro-cpp in C++23 mode.
+ target_compile_definitions(avrocpp_s PUBLIC FMT_CONSTEVAL=)
Review Comment:
It seems PRIVATE won't work :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
