fallintoplace commented on PR #664: URL: https://github.com/apache/iceberg-cpp/pull/664#issuecomment-4516681338
Updated after the review feedback: - bind file filters against `DataFile` metadata with an empty `partition` struct, matching Java `ManifestGroup` - make concrete `partition.*` file filters fail during binding instead of exposing implementation-specific partition field names - expose `spec_id` through `DataFileStructLike` for file-level filters - return null for empty container-backed optional metadata - use `std::span` in the vector-backed array wrapper - refresh regression tests for record count, selected metadata columns, `spec_id`, and rejected partition metadata filters Local validation passed with pre-commit, the focused `FilterFiles*` manifest tests, and the full `manifest_test` suite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
