wombatu-kun commented on code in PR #16438:
URL: https://github.com/apache/iceberg/pull/16438#discussion_r3287015223
##########
kafka-connect/kafka-connect-runtime/src/integration/java/org/apache/iceberg/connect/IntegrationTestBase.java:
##########
@@ -58,6 +58,7 @@ public abstract class IntegrationTestBase {
private Admin admin;
private String connectorName;
private String testTopic;
+ private String controlTopic;
Review Comment:
You're right — it's not needed. The control-topic isolation was my original
hypothesis, before the stack trace pinned the flake to the
`ConcurrentModificationException` in `IcebergSinkConfig.tableConfig`. The
one-line `Maps.newConcurrentMap()` fix eliminates the race at its source, so
the per-test control topic only mitigated a symptom. I've dropped that commit
and force-pushed; the PR is now just the single-line thread-safety fix
(`1915c991c`).
While you're already in context here: could you also take a look at the
companion PR #16504? It adds the per-test integration-test reports and Docker
container log capture — without that log capture we would never have surfaced
the CME stack trace and pinned down the root cause. The artifacts produced by
the commits originally in this PR can be seen in this CI run:
https://github.com/apache/iceberg/actions/runs/26213568037.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
