gaborkaszab commented on code in PR #15903:
URL: https://github.com/apache/iceberg/pull/15903#discussion_r3287281907
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalogProperties.java:
##########
@@ -69,25 +66,5 @@ public enum SnapshotMode {
public enum ScanPlanningMode {
CLIENT,
SERVER;
-
- public String modeName() {
- return name().toLowerCase(Locale.ROOT);
- }
-
- public static ScanPlanningMode fromString(String mode) {
- for (ScanPlanningMode planningMode : values()) {
- if (planningMode.modeName().equalsIgnoreCase(mode)) {
- return planningMode;
- }
- }
-
- throw new IllegalArgumentException(
- String.format(
- "Invalid scan planning mode: %s. Valid values are: %s",
- mode,
- Arrays.stream(values())
- .map(ScanPlanningMode::modeName)
- .collect(Collectors.joining(", "))));
- }
Review Comment:
This is somewhat unrelated to the scope of the PR. May I move this into a
separate PR and continue the discussion there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
