bodduv opened a new pull request, #14500:
URL: https://github.com/apache/iceberg/pull/14500

   Fixes #14216
   
   The problem is described in the issue as well as in the [dev mailing list 
post]( https://lists.apache.org/thread/6r4fkho84z4240fpk4kl5bnlf542n0pm).
   
   The changes proposed in the PR take a simple approach to fix the comparisons 
bug. This directly addresses correctness issues at both `ManifestEntry` as well 
as `ManifestFile` filtering. Note that the changes make UUID values comparison 
forward-compatible, but compliant with UUID RFCs.
   
   Additionally, the changes here maintain backward compatibility with files 
written before RFC 4122/9562 compliant comparison was implemented. This is 
accomplished by evaluating predicate expression once with RFC compliant 
comparator and again with signed comparator. If either of the evaluations is 
true, then the ManifestEntry or ManifestFile is filtered-in. This conservative 
approach ensures files are not skipped incorrectly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to