dramaticlly commented on code in PR #16506:
URL: https://github.com/apache/iceberg/pull/16506#discussion_r3290489068
##########
core/src/test/java/org/apache/iceberg/TestMergeAppend.java:
##########
@@ -89,7 +90,12 @@ public void testAddManyFiles() {
public void testAddManyFilesWithConsistentOrdering() {
assertThat(listManifestFiles()).as("Table should start empty").isEmpty();
- int multiplier = 3;
Review Comment:
Do we only run into this if the build only have 2 cores available?
If so we can update as Steven suggested as
```java
int multiplier = 3;
assumeThat(ThreadPools.WORKER_THREAD_POOL_SIZE).isGreaterThanOrEqualTo(multiplier);
```
verified with `ICEBERG_WORKER_NUM_THREADS=2 ./gradlew :iceberg-core:test
--tests "org.apache.iceberg.TestMergeAppend"` locally
Also plan to update this test with provided writeManifestWith pool so that
we can have deterministic behavior regardless of core available in the build
instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
