harperjiang commented on PR #16501: URL: https://github.com/apache/iceberg/pull/16501#issuecomment-4521816859
Thanks @pvary @nastra @amogh-jahagirdar for the discussion! Pushed an update: * Arrow-side test added: new `TestVectorizedDefaultValues` in the arrow module (not bolted onto `TestArrowReader`, per amogh). Class Javadoc positions it as the seed of the broader default-values suite; * Spark-side test kept for engine-integration coverage. Happy to drop it if you'd prefer. * withInitialDefault(null).withWriteDefault(null) applied per @nastra to makes the intent explicit. * Dropped the inline comment in TestParquetVectorizedReads per @amogh-jahagirdar. * Renamed getParquetWriterWithoutDictionary → parquetWriterWithoutDictionary per @amogh-jahagirdar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
