stevenzwu commented on code in PR #16174:
URL: https://github.com/apache/iceberg/pull/16174#discussion_r3291361652
##########
core/src/main/java/org/apache/iceberg/util/LocationUtil.java:
##########
@@ -64,20 +64,29 @@ public static String tableLocation(TableIdentifier
tableIdentifier, boolean useU
* section 3.1</a>.
*/
private static boolean hasScheme(String location) {
+ // RFC 3986 section 3.1: scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "."
)
Review Comment:
nit: seems like this comment is better placed at line 82 as a Javadoc
comment for the `isSchemeChar` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
