yadavay-amzn commented on PR #16434: URL: https://github.com/apache/iceberg/pull/16434#issuecomment-4523214747
Addressed all 5 points: 1. **Narrowed catch** to `CommitFailedException` only -- all other exceptions are fatal immediately (no retry for CommitStateUnknownException, ValidationException, etc.) 2. **Default changed to 1** -- preserves existing behavior out-of-the-box, users opt-in to retries 3. **Counter only resets on full-commit success** -- partial commits no longer renew the retry budget 4. **Fixed property namespace** to `iceberg.control.commit.max-consecutive-failures` (matches existing `iceberg.control.commit.*` prefix) 5. **Added reset-on-success test** -- fail, fail, succeed, fail, fail verifies counter resets correctly Thanks @laskoviymishka! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
