findinpath opened a new pull request, #16536: URL: https://github.com/apache/iceberg/pull/16536
## Problem The existing `BiFunction<SessionContext, Map<String, String>, FileIO> ioBuilder` applied storage credentials post-construction via `SupportsStorageCredential.setCredentials` method which does not work for engines (e.g. Trino) that need all inputs available at build time. ## Technical solution Introduce a `FileIOBuilder` functional interface that receives `SessionContext`, fileIO properties, and `List<StorageCredential>` all at once. Deprecate the `BiFunction` constructor with a wrapper that preserves the old two-step behavior for existing callers. ## Related issues and PRs This contribution is attempting to adjust the previous changes performed in https://github.com/apache/iceberg/pull/15752 for configuring `StorageCredentials` in the `ioBuilder`. Issue discovered while developing https://github.com/trinodb/trino/pull/29590 The Trino PR makes use of this contribution for ensuring the accuracy of these changes on https://github.com/trinodb/trino project within the Iceberg connector. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
