danielcweeks commented on a change in pull request #1844: URL: https://github.com/apache/iceberg/pull/1844#discussion_r539742821
########## File path: aws/src/main/java/org/apache/iceberg/aws/AwsClientConfigFactory.java ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.aws; + +import java.io.Serializable; +import org.apache.iceberg.catalog.CatalogConfigurable; +import software.amazon.awssdk.awscore.client.builder.AwsClientBuilder; +import software.amazon.awssdk.awscore.client.builder.AwsSyncClientBuilder; + +/** + * Interface for any customization of AWS client. + * <p> + * User can provide an implementation of this factory to perform any modification to AWS clients, + * such as credentials provider, region, endpoint, http client, etc. + * See {@link AssumeRoleClientConfigFactory} as an example. + */ +public interface AwsClientConfigFactory extends CatalogConfigurable, Serializable { Review comment: Sorry, this just dropped off my radar. I don't actually disagree with in concept with any of the items above, but I would propose handling it differently. Make AwsClientFactory an interface, which would just expose the client calls (e.g. `factory.s3()`, `factory.glue()`). Create a `DefaultAwsClientFactory` that has the common configuration `setDefaultsAndConfigure`. Create an `StsAwsClientFactory` that overrides for `setDefaultsAndConfigure` for the common functionality. Now I can see your point in #3 that is someone were to override the client creation, they would have to directly call the `setDefaultsAndConfigure`, but I don't feel like preventing users from overriding the creation of the client is a good tradeoff for ensuring that they're consistently configured. We could separate the instantiation and access of the client in the factory so that you can enforce the configure path, but I feel like that's just overcomplicating the situation. Doing the above just gets us back to a more traditional, interface and implementation design that I feel will make more sense for anyone looking to provide a custom implementation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
