ndrluis commented on PR #3405:
URL: https://github.com/apache/iceberg-python/pull/3405#issuecomment-4527116644
@fallintoplace Thank you for your contribution.
Can we also handle and add tests for large integral-looking strings that are
not plain integer literals, e.g. "9007199254740993.0", "9007199254740993e0",
and f"{LongType.max}.0"? These still go through the float path today and either
lose precision or overflow incorrectly. A test for "1e3" would also catch the
scientific-notation regression from the previous behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
