moomindani commented on PR #16250: URL: https://github.com/apache/iceberg/pull/16250#issuecomment-4532110305
Pushed `efc48d429` with documentation for `OtelMetricsReporter` in [`docs/docs/metrics-reporting.md`](https://github.com/apache/iceberg/blob/moomindani/otel-metrics-reporter/docs/docs/metrics-reporting.md). It covers: - Host responsibilities (the SDK lifecycle is owned by the host application, not by the reporter). - Packaging the OpenTelemetry API, SDK, and a metric exporter (Gradle + `spark-submit --packages` examples). - Programmatic SDK registration via `OpenTelemetrySdk.builder()...buildAndRegisterGlobal()`, with a note on the Java agent alternative. - Concrete exporter-wiring examples for the OpenTelemetry Collector, Prometheus (pull + push), and Amazon CloudWatch (SigV4 via the `sigv4auth` Collector extension). - The emitted metric names, units, source `ScanReport`/`CommitReport` fields, attribute set, and the rationale for excluding `iceberg.snapshot.id`. End-to-end verification: built `iceberg-core` at this commit, registered a host SDK that wires `PrometheusHttpServer` as a Prometheus pull-mode reader, instantiated `OtelMetricsReporter` reflectively as a catalog would, reported synthetic `ScanReport` + `CommitReport`, and confirmed via `curl localhost:9464/metrics` that all 12 `iceberg.*` series show up with the documented attribute set and that `iceberg.snapshot.id` is absent. Each Collector YAML in the docs was also `otelcol-contrib validate`-checked. Addresses @jbonofre's documentation request on the [dev@ thread](https://lists.apache.org/thread/vn4gglocg2g40p69mfrrh86qzkn1rr4b). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
