TwinklerG commented on PR #2504: URL: https://github.com/apache/iceberg-rust/pull/2504#issuecomment-4534138809
> > > Thanks @TwinklerG for this pr. We already have `taplo check` in Makefile, and I think what's missing is just adding them in github workflow. I think we could add one step in check job of ci.yml > > > > > > Thanks @blackmwk for comments. `taplo check` only checks the syntax, not the formatting. We need `taplo fmt --check` to ensure TOML files are formatted. > > Thanks for the explaination, in this case we should subsitute `taplo fmt --check` for the exisiting `taplo check`. Thanks for your guide. I have fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
