blackmwk commented on PR #2489: URL: https://github.com/apache/iceberg-rust/pull/2489#issuecomment-4534346892
> LGTM > > Looks like we're adding 2 new crates `iceberg-cache-moka` and `iceberg-catalog-loader`. I see you've added catagory/description/keyword to `iceberg-cache-moka`. Is the `iceberg-catalog-loader` change intentional? > > Crate Path In old matrix? > `iceberg` crates/iceberg/Cargo.toml yes > `iceberg-storage-opendal` crates/storage/opendal/Cargo.toml yes > `iceberg-catalog-glue` crates/catalog/glue/Cargo.toml yes > `iceberg-catalog-hms` crates/catalog/hms/Cargo.toml yes > `iceberg-catalog-rest` crates/catalog/rest/Cargo.toml yes > `iceberg-catalog-s3tables` crates/catalog/s3tables/Cargo.toml yes > `iceberg-catalog-sql` crates/catalog/sql/Cargo.toml yes > `iceberg-datafusion` crates/integrations/datafusion/Cargo.toml yes > `iceberg-cache-moka` crates/integrations/cache-moka/Cargo.toml **new** > `iceberg-catalog-loader` crates/catalog/loader/Cargo.toml **new** > Nit: Also might be better to add > > ``` > [workspace.package] > publish = false > ``` > > to the workspace `Cargo.toml` so all crates are not published by default. This can prevent a new crate from being published accidentally (with the current approach, someone has to remember to set `publish = false`) Done, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
