kevinjqliu commented on code in PR #2506: URL: https://github.com/apache/iceberg-rust/pull/2506#discussion_r3299217410
########## bindings/python/pyproject.toml: ########## @@ -40,6 +40,7 @@ readme = "project-description.md" requires-python = ">=3.10,<4" [tool.maturin] +config = ["profile.release.lto=\"thin\""] Review Comment: isolating to pyproject since we only want this option for pyiceberg-core. note that it cannot be set in `bindings/python/Cargo.toml` because Cargo forbids `[profile.*]` sections in workspace and cannot be set in root `Cargo.toml`because per-package override (`[profile.release.package.pyiceberg_core_rust]`) only supports compile-time settings (opt-level, codegen-units, strip, etc.). `lto` is a linker-level setting that applies to the final artifact link step, so Cargo rejects it in per-package overrides -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
