stevenzwu commented on code in PR #12584:
URL: https://github.com/apache/iceberg/pull/12584#discussion_r3299366739
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3964,6 +4144,292 @@ components:
metadata:
$ref: '#/components/schemas/TableMetadata'
+ EventsResponse:
+ type: object
+ required:
+ - highest-processed-timestamp-ms
+ - events
+ properties:
+ next-page-token:
+ $ref: "#/components/schemas/PageToken"
+ highest-processed-timestamp-ms:
Review Comment:
With the field marked required and described as informational ("processed up
to X" for client display), every server has to compute and surface it on every
page even when filters mean it adds no signal beyond the events array.
Since the client won't use this field as the next request's continuation
point, I am wondering if this field is useful at all especially if it is not
monotonic.
I would favor removing it entirely. If not, at least we can downgrade it
from required to optional so servers can omit when not useful. We can always
add it in the future if it is found useful later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
