gaborkaszab commented on code in PR #16125:
URL: https://github.com/apache/iceberg/pull/16125#discussion_r3303492995
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -1623,6 +1630,7 @@ public void testPartitionsTableLastUpdatedSnapshot() {
}
@Test
+ @SuppressWarnings("checkstyle:MethodLength")
Review Comment:
Do we still need this?
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -1749,6 +1759,7 @@ public void testPartitionsTableDeleteStats() {
.set("position_delete_file_count", 0)
.set("equality_delete_record_count", 2L) // should be incremented
now
.set("equality_delete_file_count", 2) // should be incremented now
+ .set("dv_count", 0)
Review Comment:
I quickly went through the tests and I see that we still don't test when the
dv_count is not zero. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
