gabeiglio commented on code in PR #3415:
URL: https://github.com/apache/iceberg-python/pull/3415#discussion_r3303700744
##########
pyiceberg/catalog/__init__.py:
##########
@@ -744,6 +745,48 @@ def create_view(
ViewAlreadyExistsError: If a view with the name already exists.
"""
+ def create_sql_view(
+ self,
+ identifier: str | Identifier,
+ schema: Schema | pa.Schema,
+ dialect: str,
+ sql: str,
+ default_namespace: Identifier,
Review Comment:
Nit: we should allow default_namespace to be `str | Identfier`, and do:
```python
namespace_tuple = self._check_valid_namespace_identifier(namespace)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
