SreeramGarlapati opened a new pull request, #2514: URL: https://github.com/apache/iceberg-rust/pull/2514
## Which issue does this PR close? Follow-up to review feedback on #2511 ([thread](https://github.com/apache/iceberg-rust/pull/2511#discussion_r-blackmwk-dead-code)). ## What changes are included in this PR? Removes all four `#[allow(dead_code)]` attributes in `crates/iceberg/src/spec/snapshot_summary.rs`. They were added in #1085 when the module was first introduced, before any caller existed. The chain is now production-live: - `update_snapshot_summaries` is called from `transaction/snapshot.rs` - `truncate_table_summary` is called from `update_snapshot_summaries` - `get_prop` is called 6 times from `truncate_table_summary` - `update_totals` is called 6 times from `update_snapshot_summaries` None of these need the suppression any more — the dead_code lint is silent without them. Kept out of #2511 to keep that PR's scope focused on the overwrite-truncate panic fix. ## Are these changes tested? `cargo check -p iceberg` and `cargo clippy -p iceberg --all-features --tests -- -D warnings` both stay clean after the removals — i.e. no dead_code warning re-emerges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
