SreeramGarlapati commented on code in PR #2511:
URL: https://github.com/apache/iceberg-rust/pull/2511#discussion_r3305138491


##########
crates/iceberg/src/spec/snapshot_summary.rs:
##########
@@ -409,16 +407,16 @@ pub(crate) fn update_snapshot_summaries(
 }
 
 #[allow(dead_code)]

Review Comment:
   Good catch — but keeping this PR's scope tight to the panic fix. Opened 
#2514 as a follow-up that drops all four stale `#[allow(dead_code)]` attributes 
in this file (this one plus the ones on `update_snapshot_summaries`, 
`truncate_table_summary`, and `update_totals` — all stale for the same reason). 
Verified `cargo check` and `cargo clippy --all-features --tests -- -D warnings` 
stay clean after the removals.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to