zeroshade commented on code in PR #1129:
URL: https://github.com/apache/iceberg-go/pull/1129#discussion_r3305310259
##########
manifest.go:
##########
@@ -414,18 +415,19 @@ func getFieldIDMap(sc *avro.Schema) (map[string]int,
map[int]string, map[int]int
if typ.LogicalType != "" {
logicalTypes[fid] = typ.LogicalType
if typ.LogicalType == atype.Decimal {
- fixedSizes[fid] = typ.Scale
+ decimalScales[fid] = typ.Scale
+ decimalPrecisions[fid] = typ.Precision
}
}
}
- return result, logicalTypes, fixedSizes
+ return result, logicalTypes, decimalScales, decimalPrecisions
Review Comment:
can we combine the `decimalScales` and `decimalPrecisions` into a single
that maps the fieldID to a combined scale and precision? Compacting that would
be better than having two separate maps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
