marton-bod commented on a change in pull request #1897:
URL: https://github.com/apache/iceberg/pull/1897#discussion_r540024234
##########
File path:
hive3/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspectorHive3.java
##########
@@ -20,50 +20,32 @@
package org.apache.iceberg.mr.hive.serde.objectinspector;
import java.time.LocalDateTime;
-import java.time.OffsetDateTime;
import java.time.ZoneOffset;
import org.apache.hadoop.hive.common.type.Timestamp;
import org.apache.hadoop.hive.serde2.io.TimestampWritableV2;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.AbstractPrimitiveJavaObjectInspector;
import
org.apache.hadoop.hive.serde2.objectinspector.primitive.TimestampObjectInspector;
import org.apache.hadoop.hive.serde2.typeinfo.TypeInfoFactory;
-public abstract class IcebergTimestampObjectInspectorHive3 extends
AbstractPrimitiveJavaObjectInspector
+public class IcebergTimestampObjectInspectorHive3 extends
AbstractPrimitiveJavaObjectInspector
Review comment:
I've done a merge with master, and this class
`IcebergTimestampObjectInspectorHive3` doesn't seem to implement
`WriteObjectInspector` yet even on master. I can add a similar convert method
that we have for `IcebergTimestampObjectInspector`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
