pvary commented on code in PR #16243:
URL: https://github.com/apache/iceberg/pull/16243#discussion_r3311406096
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/HashKeyGenerator.java:
##########
@@ -79,6 +78,9 @@ int generateKey(
@Nullable PartitionSpec tableSpec,
@Nullable RowData overrideRowData) {
String tableIdent = dynamicRecord.tableIdentifier().toString();
+ Schema effectiveSchema = MoreObjects.firstNonNull(tableSchema,
dynamicRecord.schema());
+ Set<String> effectiveEqualityFields =
+
DynamicSinkUtil.resolveEqualityFieldNames(dynamicRecord.equalityFields(),
effectiveSchema);
Review Comment:
Shall we pre-calculate the distribution mode too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
