RussellSpitzer commented on PR #16424: URL: https://github.com/apache/iceberg/pull/16424#issuecomment-4557508189
My gut reading here is that we shouldn't be changing StructInternalRow, calling "getString" on a non string object should not default to calling "toString" on that object. This would just silently widen types in a way that we don't do anywhere else. It feels like we are fixing a bad caller by changing the behavior rather than fixing the caller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
