rdblue commented on code in PR #16500: URL: https://github.com/apache/iceberg/pull/16500#discussion_r3313204032
########## data/src/test/java/org/apache/iceberg/TestBaseDeleteLoader.java: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import org.apache.iceberg.data.BaseDeleteLoader; +import org.apache.iceberg.data.DeleteLoader; +import org.apache.iceberg.io.InputFile; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.junit.jupiter.api.Test; + +public class TestBaseDeleteLoader { + + private static final String DATA_FILE = "/tmp/data.parquet"; + + private static final DeleteFile VALID_DV = + FileMetadata.deleteFileBuilder(PartitionSpec.unpartitioned()) + .ofPositionDeletes() + .withFormat(FileFormat.PUFFIN) + .withPath("/tmp/dv.puffin") + .withFileSizeInBytes(10) + .withRecordCount(1) + .withReferencedDataFile(DATA_FILE) + .withContentOffset(0L) + .withContentSizeInBytes(10L) + .build(); + + @Test + public void loadPositionDeletesRejectsNegativeContentOffset() { + DeleteFile dv = tamperedDV(-1L, 10L); + DeleteLoader loader = new BaseDeleteLoader(file -> failingInputFile()); + + assertThatThrownBy(() -> loader.loadPositionDeletes(ImmutableList.of(dv), DATA_FILE)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessageContaining("offset must be non-negative"); + } + + @Test + public void loadPositionDeletesRejectsNegativeContentSize() { + DeleteFile dv = tamperedDV(0L, -1L); + DeleteLoader loader = new BaseDeleteLoader(file -> failingInputFile()); + + assertThatThrownBy(() -> loader.loadPositionDeletes(ImmutableList.of(dv), DATA_FILE)) + .isInstanceOf(IllegalArgumentException.class) + .hasMessageContaining("length must be non-negative"); + } + + // Wraps a well-formed DV but reports tampered (offset, size). Simulates a corrupted manifest, + // since the FileMetadata builder now rejects negative values at construction time. + private static DeleteFile tamperedDV(Long offset, Long size) { + return new Delegates.DelegatingDeleteFile(VALID_DV) { Review Comment: I think this is too clever and it's odd that the same PR has multiple ways to inject a delete with an invalid offset or size. I think this should pick one strategy. I think it probably makes more sense to use a mock, but I don't have a strong opinion. Also, it would be reasonable (and straightforward) to just use the `DeleteFile` constructor and bypass the builder rather than doing things like this. The actual class allows these values because we don't validate and fail while filling the objects with data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
