vladislav-sidorovich commented on PR #16055: URL: https://github.com/apache/iceberg/pull/16055#issuecomment-4558023439
> > > Thanks @vladislav-sidorovich and @anoopj for reviewing! This looks right to me, but I think we should also get @danielcweeks input on this as well. I'm curious if you've seen issues with EOF exceptions in practice? My guess is so far we've largely been getting lucky because we issue targeted range reads / always reading the appropriate length from metadata. > > > > > > I was only reviewing GCP module to check if we have any issues and find it. I believe in PROD usage buffered reader was used, so the problems were minor metrics inaccuracies. > > @danielcweeks would you be able to take a look on the PR? @danielcweeks would you be able to take a look on the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
