rambleraptor commented on code in PR #2149:
URL: https://github.com/apache/iceberg-python/pull/2149#discussion_r3313772687
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -1471,6 +1474,28 @@ def drop_view(self, identifier: str | Identifier) ->
None:
except HTTPError as exc:
_handle_non_200_response(exc, {404: NoSuchViewError})
+ @retry(**_RETRY_ARGS)
+ def rename_view(self, from_identifier: str | Identifier, to_identifier:
str | Identifier) -> None:
+ payload = {
+ "source": self._split_identifier_for_json(from_identifier),
+ "destination": self._split_identifier_for_json(to_identifier),
+ }
+
+ # Ensure source and destination namespaces exist before rename.
+ source_namespace =
self._split_identifier_for_json(from_identifier)["namespace"]
+ dest_namespace =
self._split_identifier_for_path(to_identifier)["namespace"]
Review Comment:
json is fine. Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
