danielcweeks commented on code in PR #16572:
URL: https://github.com/apache/iceberg/pull/16572#discussion_r3313979286
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -312,6 +313,10 @@ public String toString() {
SUPPORTED_TABLE_FORMAT_VERSION);
Preconditions.checkArgument(
formatVersion == 1 || uuid != null, "UUID is required in format v%s",
formatVersion);
+ Preconditions.checkArgument(
Review Comment:
A location should start with a URI scheme, not a `/`. For fields in
metadata files, if a path starts with `/` it was likely introduced out of spec
(even v3 and prior required a fully-qualified or URI with scheme value). We
shouldn't allow for `/` prefixed paths in table metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
