CTTY commented on code in PR #2253:
URL: https://github.com/apache/iceberg-rust/pull/2253#discussion_r3314619510
##########
.github/workflows/ci_hf_cdc.yml:
##########
@@ -65,16 +78,20 @@ jobs:
HF_BUCKET: ${{ secrets.HF_BUCKET }}
HF_DATASET: ${{ secrets.HF_DATASET }}
run: |
- cargo test -p iceberg-storage-opendal \
- --features opendal-hf \
- --test file_io_hf_test \
- -- --test-threads=1
+ # All HF tests are named with `_hf` (rstest matrix cases) or `hf_`
+ # (standalone HF-only tests) and are marked `#[ignore]` so they're
+ # skipped by default. Match those name patterns explicitly so adding
+ # other ignored tests later won't accidentally pull them in here.
+ cargo test -p iceberg-storage-common \
+ --test file_io_suite \
+ --test resolving_suite \
+ -- --ignored --test-threads=1 _hf hf_
Review Comment:
This feels kinda hacky and makes me think if we should just leave hf io
tests alone. curious to hear what others think
##########
.github/workflows/ci_hf_cdc.yml:
##########
@@ -65,16 +78,20 @@ jobs:
HF_BUCKET: ${{ secrets.HF_BUCKET }}
HF_DATASET: ${{ secrets.HF_DATASET }}
run: |
- cargo test -p iceberg-storage-opendal \
- --features opendal-hf \
- --test file_io_hf_test \
- -- --test-threads=1
+ # All HF tests are named with `_hf` (rstest matrix cases) or `hf_`
+ # (standalone HF-only tests) and are marked `#[ignore]` so they're
+ # skipped by default. Match those name patterns explicitly so adding
+ # other ignored tests later won't accidentally pull them in here.
+ cargo test -p iceberg-storage-common \
+ --test file_io_suite \
+ --test resolving_suite \
+ -- --ignored --test-threads=1 _hf hf_
Review Comment:
This feels kinda hacky and makes me think if we should just leave hf io
tests alone. curious to hear what others think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
