lrsb commented on code in PR #16011:
URL: https://github.com/apache/iceberg/pull/16011#discussion_r3316174102
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicCommitter.java:
##########
@@ -512,8 +607,7 @@ void testTableBranchAtomicCommitForAppendOnlyData() throws
Exception {
// Two committables, one for each snapshot / table / branch.
assertThat(table.snapshots()).hasSize(2);
- Snapshot snapshot1 = Iterables.getFirst(table.snapshots(), null);
-
assertThat(snapshot1.snapshotId()).isEqualTo(table.refs().get("branch1").snapshotId());
Review Comment:
> The question is: do we have tests that ensure that if we commit them in
the same cycle, they are committed in the expected order?
The order between different branches or different tables depends on the
HashMap order, which can reorder a ckpt=2 branch-B commit before a ckpt=1
branch-A commit.
> The question is: do we have tests that ensure that if we commit them in
the same cycle, they are committed in the expected order?
The order of commits within the same cycle is currently not covered well,
testSkipsAlreadyCommittedDataAfterJobIdChange covers just the single commit
case. Will add a new test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
