AnatolyPopov commented on code in PR #16453:
URL: https://github.com/apache/iceberg/pull/16453#discussion_r3324864327
##########
kafka-connect/kafka-connect-runtime/src/integration/java/org/apache/iceberg/connect/IntegrationTestBase.java:
##########
@@ -201,7 +201,8 @@ protected KafkaConnectUtils.Config
createCommonConfig(boolean useSchema) {
.config("value.converter.schemas.enable", useSchema)
.config("iceberg.control.commit.interval-ms", 1000)
.config("iceberg.control.commit.timeout-ms", Integer.MAX_VALUE)
- .config("iceberg.kafka.auto.offset.reset", "earliest");
+ .config("iceberg.kafka.auto.offset.reset", "earliest")
+ .config("offset.flush.interval.ms", 500);
Review Comment:
Are you sure it helps with the tests stablilization? in this case it will be
passed as part of the connector config but I sink it is worker-only config so
will it be just ignored? Also the same value is specified in the worker config
here
https://github.com/apache/iceberg/blob/main/kafka-connect/kafka-connect-runtime/docker/docker-compose.yml#L108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
