gaborkaszab commented on code in PR #16408:
URL: https://github.com/apache/iceberg/pull/16408#discussion_r3324173342
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -249,95 +254,43 @@ protected <T> void internalSet(int pos, T value) {
}
}
- static Builder builder() {
- return new Builder();
+ /** Creates a builder for a newly added file in the given snapshot. */
+ static TrackingBuilder added(long snapshotId) {
Review Comment:
Can't we return a Tracking here instead of the Builder? Is there anything
else we can set on an ADDED entry? If we set anything it'd be MODIFIED instead,
right? For modified would it make sense to keep a separate builder method?
Maybe `Tracking asAdded(long)` for this one and `TrackingBuilder
asModified(long)` for modified status?
Edit: I see we keep `builder` for EXISTING and MODIFIED. My comment still
stands for ADDED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
