rambleraptor commented on PR #3364: URL: https://github.com/apache/iceberg-python/pull/3364#issuecomment-4579692272
Thanks for your patience on this! Can we get this split into two PRs? There's a couple things happening here all at once that make the review difficult. - Creating the BaseScan abstract class + moving up methods - Adding IncrementalAppendScan I don't want to have these two conversations mixed up too much. It'll make the diffs much easier to read for everyone (myself included). Thanks a lot for your hard work on this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
