Kurtiscwright commented on code in PR #2417:
URL: https://github.com/apache/iceberg-rust/pull/2417#discussion_r3327245401
##########
crates/iceberg/src/spec/table_metadata.rs:
##########
@@ -3591,6 +3644,91 @@ mod tests {
);
}
+ #[test]
+ fn test_table_metadata_builder_rejects_v1_v2_nanosecond_timestamp_tables()
{
+ for (format_version, primitive_type) in [
+ (FormatVersion::V1, PrimitiveType::TimestampNs),
+ (FormatVersion::V1, PrimitiveType::TimestamptzNs),
+ (FormatVersion::V2, PrimitiveType::TimestampNs),
+ (FormatVersion::V2, PrimitiveType::TimestamptzNs),
+ ] {
+ let table_creation = table_creation_with_format_version(
+ schema_with_primitive_field(primitive_type),
+ format_version,
+ );
+
+ let err =
TableMetadataBuilder::from_table_creation(table_creation).unwrap_err();
+
+ assert_eq!(err.kind(), ErrorKind::DataInvalid);
+ assert!(
+ err.message().contains("Invalid type for ts:"),
+ "expected error message to name the invalid column, got {}",
+ err.message()
+ );
+ assert!(
+ err.message().contains("is not supported until v3"),
+ "expected error message to explain v3 requirement, got {}",
+ err.message()
+ );
+ }
+ }
+
+ #[test]
+ fn test_table_metadata_builder_rejects_v2_list_element_requiring_v3() {
Review Comment:
Thank you for including, I was going to request a nested data type unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
