shanzi commented on code in PR #16545: URL: https://github.com/apache/iceberg/pull/16545#discussion_r3328225775
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java: ########## Review Comment: This seems to be a reason we keep wakeUp emtpy. Let me investigate more to see how can we avoid blockings on canceling while don't break the watermark alignment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
