adamdavis99 opened a new pull request, #3446:
URL: https://github.com/apache/iceberg-python/pull/3446
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
Closes #3410
# Rationale for this change
Extracts `SigV4Adapter` and related signing constants out of the nested
closure inside `RestCatalog._init_sigv4` into a dedicated module
`pyiceberg/catalog/rest/sigv4.py`. Separating concerns makes the signing logic
easier to evolve, test, and extend independently of the catalog (e.g., retry
config improvements tracked in #3008).
## Are these changes tested?
Yes. The existing 9 sigv4 tests in `tests/catalog/test_rest.py` cover
`sigv4.py` at 100%. No new tests were added as this is a behavior-preserving
refactor.
## Are there any user-facing changes?
`SigV4Adapter` is now a module-level class and explicitly re-exported from
`pyiceberg.catalog.rest`. All existing imports continue to work unchanged. The
previously private `RestCatalog._init_sigv4` method has been removed (it was
not part of the public API).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
