algojogacor opened a new pull request, #16639: URL: https://github.com/apache/iceberg/pull/16639
This is an independent contribution and is not associated with any hackathon or competition. ## Summary Adds two new test methods to `TestParquet.java` covering the edge case where per-column statistics are disabled on more than one column simultaneously. ## Root Cause The existing test `testColumnStatisticsEnabled` only validates the single-column-disabled scenario. Issue #15347 reported that when statistics are disabled on multiple columns (e.g., `write.parquet.stats-enabled.column.foo=false` and `write.parquet.stats-enabled.column.bar=false`), the second column may still write statistics. These tests provide coverage for that scenario. ## Changes - **`testColumnStatisticsDisabledMultipleColumns`**: Schema with 3 columns (int, string, double); stats enabled on col 1, disabled on cols 2 and 3. Verifies both disabled columns correctly omit statistics. - **`testColumnStatisticsDisabledAllColumns`**: Schema with 2 columns; stats disabled on both. Verifies every column omits statistics. ## Testing Both new tests follow the same pattern as the existing `testColumnStatisticsEnabled`: write Parquet data with the given properties, read back the footer, and assert that each ColumnChunkMetaData has the expected statistics state (empty or non-empty). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
