lawofcycles commented on code in PR #3320: URL: https://github.com/apache/iceberg-python/pull/3320#discussion_r3331524059
########## tests/integration/test_writes/test_optimistic_concurrency.py: ########## Review Comment: Added. Writing this test exposed a bug: `_OverwriteFiles` was picking up the post-_DeleteFiles snapshot as its starting point. Fixed by propagating `_starting_snapshot_id` from the delete producer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
